Skip to content

Commit ab5800d

Browse files
authored
Merge pull request #110 from salesforce/feature/funny-cases
Verify protos with strange casing generate correctly
2 parents c79814c + 053f918 commit ab5800d

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

jprotoc/jprotoc-test/src/test/java/com/salesforce/jprotoc/ProtoTypeMapTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,11 @@ public void invalidClassNames() {
9898
assertProtoTypeMapping(".com.salesforce.invalid.enye.TimeResponse", com.salesforce.invalid.enye.WeylandYutani.TimeResponse.class);
9999
}
100100

101+
@Test
102+
public void wonkyCasedNames() {
103+
assertProtoTypeMapping(".HELLOworld.HelloUPPERRequest", HELLOworld.HelloUPPERRequest.class);
104+
}
105+
101106
private void assertProtoTypeMapping(String protoTypeName, Class clazz) {
102107
assertThat(protoTypeMap.toJavaTypeName(protoTypeName)).isEqualTo(fileNameToLexicalName(clazz.getName()));
103108
}
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
syntax = "proto3";
2+
3+
option java_multiple_files = true;
4+
5+
package HELLOworld;
6+
7+
// The greeting service definition.
8+
service Greeter {
9+
// Sends a greeting
10+
rpc SayHello (HelloUPPERRequest) returns (HelloUPPERRequest) {}
11+
}
12+
13+
// The request message containing the user's name.
14+
message HelloUPPERRequest {
15+
string name = 1;
16+
}

0 commit comments

Comments
 (0)