Add a fitted box option #723
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add fitted box option
lib/src/dropdown_search.dart
Outdated
| super.onSaved, | ||
| super.validator, | ||
| super.decoratorProps, | ||
| super.onTap, |
There was a problem hiding this comment.
i do not understand why you added onTap CallBack ?
There was a problem hiding this comment.
I was looking for a callback that is executed when the DropdownSearch is pressed, later I discovered onBeforePopupOpening so I no longer use onTap and removed it.
The reason I search for onBeforePopupOpening might be useful, I had this case:
- Auth Screen with
CustomTextFormField(name, email etc) andDropdownSearchfor country selection. - Having Focus on a CustomTextFormField (keyboard shown) 👍
- Taping on
DropdownSearch(keyboard disappeared) 👍 - Selecting Item From
DropdownSearchPopup, popup closed 👍 - Focus return to last
CustomTextFormFieldand (keyboard shown) 👎
fix:
add focusNode property for each CustomTextFormField and updating the code
Old:
onTapOutside: (pointDown) {
FocusScope.of(context).unfocus();
},
New:
onTapOutside: (pointDown) {
focusNode!.unfocus();
},
After all, I neither use onTap nor onBeforePopupOpening 😄
MohammedShuqair
force-pushed
the
master
branch
from
e0fa72d to
d2e4745
Compare
This commit primarily focuses on improving the code formatting in `lib/src/base_dropdown_search.dart`. Specific changes include: - Adding trailing commas to multi-line parameter lists and typedefs. - Ensuring consistent newlines and spacing. - Reformatting conditional expressions for better clarity. - Adjusting the `fit` property of `FittedBox` to `scaleDown` for selected item display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a fitted box option for small input fields