Skip to content

Commit 11d486d

Browse files
anoopcs9mergify[bot]
authored andcommitted
images/server: Remove explicit installation of dependencies
These packages[1] are automatically pulled in with python3-sambacc extras which gets built by default and available for installation as weak dependencies. If we know that these packages[1] exists and available, then we should be good here to assume that they are pulled in during the installation of corresponding python3-sambacc extras. $ rpm -q --requires \ python3-sambacc+toml-0.8~1.g52a3e0101-1.el9.noarch.rpm | grep tomli python3.9dist(tomli) $ rpm -q --requires \ python3-sambacc+yaml-0.8~1.g52a3e0101-1.el9.noarch.rpm | grep pyyaml python3.9dist(pyyaml) >= 5.4 $ rpm -q --requires \ python3-sambacc+rados-0.8~1.g52a3e0101-1.el9.noarch.rpm | grep rados python3.9dist(rados) [1] python3-pyyaml, python3-tomli and python3-rados Signed-off-by: Anoop C S <anoopcs@samba.org>
1 parent a08a938 commit 11d486d

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

images/server/install-packages.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,6 @@ case "${package_selection}-${OS_BASE}" in
201201
*-centos|forcedevbuilds-*)
202202
support_packages+=(libcephfs-proxy2)
203203
samba_packages+=(samba-vfs-cephfs samba-vfs-glusterfs ctdb-ceph-mutex)
204-
# these packages should be installed as deps. of sambacc extras
205-
# however, the sambacc builds do not enable the extras on centos atm.
206-
# Once this is fixed this line ought to be removed.
207-
support_packages+=(python3-pyyaml python3-tomli python3-rados)
208204
;;
209205
esac
210206

0 commit comments

Comments
 (0)