Skip to content

Remove maintainers line #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 11, 2025
Merged

Remove maintainers line #222

merged 8 commits into from
Sep 11, 2025

Conversation

@phlogistonjohn
Copy link
Collaborator

@phlogistonjohn phlogistonjohn commented Sep 8, 2025

Our CI is logging warnings from docker complaining that the MAINTAINER line is deprecated. Let's modernize and remove that line.

Fixes: #214

anoopcs9
anoopcs9 approved these changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@phlogistonjohn
Copy link
Collaborator Author

phlogistonjohn commented Sep 9, 2025

@Mergifyio rebase

@phlogistonjohn
ad-server: remove MAINTAINER line
3f0bb48 
Remove MAINTAINER line from centos/fedora Container files.
Replace with a org.opencontainers.image.authors label.
Ensure labels are standard across the centos/fedora image files.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
client: remove MAINTAINER line
66838bf 
Remove MAINTAINER line from centos/fedora Container files.
Replace with a org.opencontainers.image.authors label.
Ensure labels are standard across the centos/fedora image files.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
server: remove MAINTAINER line
c74325e 
Remove MAINTAINER line from centos/fedora Container files.
Replace with a org.opencontainers.image.authors label.
Ensure labels are standard across the centos/fedora image files.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
server: remove MAINTAINER line
f065d4c 
Remove MAINTAINER line from centos/fedora Container files.
Replace with a org.opencontainers.image.authors label.
Ensure labels are standard across the centos/fedora image files.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
ad-server: remove maintainer line from opensuse container file
c91b201 
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
server: remove maintainer line from opensuse container file
bd89e08 
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
client: remove maintainer line from opensuse container file
117bab4 
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
toolbox: remove maintainer line from opensuse container file
6acc13a 
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@mergify
Copy link

mergify bot commented Sep 9, 2025

rebase

✅ Branch has been successfully rebased

synarete
synarete reviewed Sep 11, 2025
View reviewed changes
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but I still see those maintainers-specific labels in the Containerfile.centos|fedora|opensuse files. Why not remove those as well?

@anoopcs9
Copy link
Collaborator

anoopcs9 commented Sep 11, 2025

Looks fine but I still see those maintainers-specific labels in the Containerfile.centos|fedora|opensuse files. Why not remove those as well?

I see that all occurrences are removed. Can you please check again?

@synarete
Copy link
Collaborator

synarete commented Sep 11, 2025

Looks fine but I still see those maintainers-specific labels in the Containerfile.centos|fedora|opensuse files. Why not remove those as well?

I see that all occurrences are removed. Can you please check again?

Looks fine but I still see those maintainers-specific labels in the Containerfile.centos|fedora|opensuse files. Why not remove those as well?

I see that all occurrences are removed. Can you please check again?

I am reffering to lines like those:
https://github.com/phlogistonjohn/samba-container/blob/jjm-no-maint-line/images/ad-server/Containerfile.centos#L13
https://github.com/phlogistonjohn/samba-container/blob/jjm-no-maint-line/images/ad-server/Containerfile.fedora#L13

@anoopcs9
Copy link
Collaborator

anoopcs9 commented Sep 11, 2025

Looks fine but I still see those maintainers-specific labels in the Containerfile.centos|fedora|opensuse files. Why not remove those as well?

I see that all occurrences are removed. Can you please check again?

I am reffering to lines like those: https://github.com/phlogistonjohn/samba-container/blob/jjm-no-maint-line/images/ad-server/Containerfile.centos#L13 https://github.com/phlogistonjohn/samba-container/blob/jjm-no-maint-line/images/ad-server/Containerfile.fedora#L13

IIUC, the purpose of the PR is to no longer use deprecated MAINTAINER instruction rather labels (see linked #214).

@synarete
Copy link
Collaborator

synarete commented Sep 11, 2025

Looks fine but I still see those maintainers-specific labels in the Containerfile.centos|fedora|opensuse files. Why not remove those as well?

I see that all occurrences are removed. Can you please check again?

I am reffering to lines like those: https://github.com/phlogistonjohn/samba-container/blob/jjm-no-maint-line/images/ad-server/Containerfile.centos#L13 https://github.com/phlogistonjohn/samba-container/blob/jjm-no-maint-line/images/ad-server/Containerfile.fedora#L13

IIUC, the purpose of the PR is to no longer use deprecated MAINTAINER instruction rather labels (see linked #214).

Oops -- my bad.

@synarete
Copy link
Collaborator

synarete commented Sep 11, 2025

LGTM

synarete
synarete approved these changes Sep 11, 2025
View reviewed changes
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 0b8869b into samba-in-kubernetes:master Sep 11, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anoopcs9 anoopcs9 anoopcs9 approved these changes

@synarete synarete synarete approved these changes

@spuiuk spuiuk Awaiting requested review from spuiuk

@obnoxxx obnoxxx Awaiting requested review from obnoxxx

@avanthakkar avanthakkar Awaiting requested review from avanthakkar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Maintainer instruction is deprecated

3 participants

@phlogistonjohn @anoopcs9 @synarete