Skip to content

Commit 5fdcef8

Browse files
committed
dockerfile: fix wrong args order
Commit 47959b5 (image: allow passing explicit samba base-image) introduced the ability to set explicit base image and tag via command line args. However, it also introduced a bug in the Dockerfile flow which causes version and commit-id not to propagate properly into smbmetrics binary. Signed-off-by: Shachar Sharon <ssharon@redhat.com>
1 parent 5aa2c4e commit 5fdcef8

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

Dockerfile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
1-
# Args
21
ARG BASE_IMG="quay.io/samba.org/samba-server:latest"
3-
ARG GIT_VERSION="(unset)"
4-
ARG COMMIT_ID="(unset)"
5-
ARG ARCH=""
62

73
# Build smbmetrics
84
FROM docker.io/golang:1.24 AS builder
5+
ARG GIT_VERSION="(unset)"
6+
ARG COMMIT_ID="(unset)"
7+
ARG ARCH=""
98

109
WORKDIR /workspace
1110
# Copy the Go Modules manifests

0 commit comments

Comments
 (0)