Skip to content

project updates pre release 0.8 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 12, 2025
Merged

project updates pre release 0.8 #33

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a3dbbe
build: require golang 1.24 or later
synarete Nov 9, 2025
9ea2703
image: use golang builder 1.25
synarete Nov 9, 2025
9ca4158
hack: upgrade golangci-lint to v2.6.1
synarete Nov 9, 2025
79a7fc5
workflows: upgrade setup-go and checkout actions
synarete Nov 9, 2025
a18ca7c
workflows: use explicit hash for github actions
synarete Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,20 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v5
- uses: actions/setup-go@v6
Copy link
Collaborator

@phlogistonjohn phlogistonjohn Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, I'm happy to approve - however some projects have been switching to use hashes to be me more secure against possible future malicious versions:
https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions

Since you're touching a lot of these now it might be worth adopting that practice too, but I won't insist on it at this time.

Copy link
Collaborator Author

@synarete synarete Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting -- I was not aware. Will dig into it and see how it goes...

Copy link
Collaborator Author

@synarete synarete Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed another commit with explicit git-hash instead of tags. Not sure if this is the proper/recommended way. @phlogistonjohn WDYT ?

Copy link
Collaborator

@phlogistonjohn phlogistonjohn Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me.

with:
go-version: "stable"
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Build
run: make
# Run static/code-quality checks
check:
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v5
- uses: actions/setup-go@v6
with:
go-version: "stable"
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Install build tools
run: make build-tools
- name: Run checks
Expand All @@ -36,7 +36,7 @@ jobs:
runs-on: ubuntu-latest
if: github.event_name == 'pull_request'
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
Expand All @@ -48,10 +48,10 @@ jobs:
needs: [build, check]
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v5
- uses: actions/setup-go@v6
with:
go-version: "stable"
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Run tests
run: make test
podmanbuild:
Expand All @@ -60,7 +60,7 @@ jobs:
# image build step, so no need to do it twice.
if: github.event_name == 'pull_request'
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Install fuse-overlayfs
run: sudo apt-get -y install fuse-overlayfs
- name: Setup podman config
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
# image build step, so no need to do it twice.
if: github.event_name == 'pull_request'
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: build container image
# note: forcing use of podman here since we are
# using podman explicitly for the push job
Expand All @@ -99,7 +99,7 @@ jobs:
runs-on: ubuntu-latest
if: github.event_name == 'push'
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: log in to quay.io
# using docker for now, since podman has an issue with space
# consumption: image build fails with no space left on device...
Expand Down
Loading