add missing attribute for js-module tag #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was causing obscure bug during installation with older version of nodejs, as is the case when using meteor (uses its own version of node currently at v0.10.41 where the 'path' package doesn't have the 'parse' method (see error below):
=> Errors executing Cordova commands:
While adding plugin cordova-plugin-app-version@0.1.8 to Cordova project:
TypeError: Uh oh!
Object [object Object] has no method 'parse'
at handlers.js-module.install (//.meteor/local/cordova-build/platforms/android/cordova/lib/pluginHandlers.js:142:66)
and the culprit code (last line falls back to parsing the src attribute for a name if name is not defined):
Defining the name attribute just avoids this mess :-)