Add compatibility with the SmartPunctExtension #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This duplicates most of the code from the SmartPunctExtension in order to make it work for LaTeX-style quotes and ellipses and to remove its handling of dashes. Ideally most of these classes would be able to extend their SmartPunctExtension counterparts, but those are `final` and so this is the hacky workaround. Refs #12
|
This isn't the most elegant but will do for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This duplicates most of the code from the SmartPunctExtension in order to make it work for LaTeX-style quotes and ellipses and to remove its handling of dashes.
Ideally most of these classes would be able to extend their SmartPunctExtension counterparts, but those are
finaland so this is the hacky workaround.Refs #12