Some cleanup of the STK classes, mostly field containers #1158
+349
−654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to make the logically extruded mesh/disc save the solution into the basal mesh, and ran into issues regarding wrong layouts (as the basal disc already defines a solution, with layout matching the extents of the basal mesh).
In order to be more free to add the solution field in the basal mesh, I had to cleanup and rework a few things, and ended up cleaning a bit of other stuff in the STK stack. Below is a sumamry of the main changes.
Tests pass on my workstation (except the known fail of NullSpace utils).