-
Notifications
You must be signed in to change notification settings - Fork 5
ci: Ensure SSH client is installed #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's needed by the Semantic Release workflow to sign the releases. I'm not sure why this step wasn't needed in the past, but within the past week the Semantic Release job has failed intermittently, meaning certain runners using ubuntu-latest have it installed, while others do not.
Reviewer's GuideThis PR updates the semantic-release CI workflow to explicitly install the SSH client required for release signing and standardizes the indentation of workflow steps for consistency. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Sorry about the diff. VS Code automatically indented a bunch of stuff for me. The relevant addition is - name: Install openssh-client
run: sudo apt-get update && sudo apt-get install -y openssh-client |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
=======================================
Coverage 94.01% 94.01%
=======================================
Files 2 2
Lines 167 167
Branches 37 37
=======================================
Hits 157 157
Misses 4 4
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good to me. Probably needed due to some change in the base OS. |
|
Well shoot. We still run into Is it perhaps a flaw in |
|
Filed python-semantic-release/python-semantic-release#1376 to see if we can get some guidance. |
It's needed by the Semantic Release workflow to sign the releases. I'm not sure why this step wasn't needed in the past, but within the past week the Semantic Release job has failed intermittently, meaning certain runners using ubuntu-latest have it installed, while others do not.
Here's an example of a failing job.
@jcox10, does this solution make sense to you?
Summary by Sourcery
CI: