Skip to content

Conversation

@jmgate
Copy link
Collaborator

@jmgate jmgate commented Nov 17, 2025

It's needed by the Semantic Release workflow to sign the releases. I'm not sure why this step wasn't needed in the past, but within the past week the Semantic Release job has failed intermittently, meaning certain runners using ubuntu-latest have it installed, while others do not.

Here's an example of a failing job.

@jcox10, does this solution make sense to you?

Summary by Sourcery

CI:

  • Install openssh-client via apt-get in the semantic-release job

It's needed by the Semantic Release workflow to sign the releases.  I'm
not sure why this step wasn't needed in the past, but within the past
week the Semantic Release job has failed intermittently, meaning certain
runners using ubuntu-latest have it installed, while others do not.
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 17, 2025

Reviewer's Guide

This PR updates the semantic-release CI workflow to explicitly install the SSH client required for release signing and standardizes the indentation of workflow steps for consistency.

File-Level Changes

Change Details Files
Add openssh-client installation step
  • Update apt cache and install openssh-client before running semantic-release
.github/workflows/semantic-release.yml
Standardize workflow YAML indentation
  • Re-indent steps under each job to align dash prefixes and nested fields
.github/workflows/semantic-release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jmgate
Copy link
Collaborator Author

jmgate commented Nov 17, 2025

Sorry about the diff. VS Code automatically indented a bunch of stuff for me. The relevant addition is

    - name: Install openssh-client
      run: sudo apt-get update && sudo apt-get install -y openssh-client

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.01%. Comparing base (fab662e) to head (1993c3d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files           2        2           
  Lines         167      167           
  Branches       37       37           
=======================================
  Hits          157      157           
  Misses          4        4           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jcox10 jcox10 self-assigned this Nov 20, 2025
@jcox10
Copy link
Collaborator

jcox10 commented Nov 20, 2025

Looks good to me. Probably needed due to some change in the base OS.

@jmgate jmgate merged commit 80c7018 into master Nov 20, 2025
15 checks passed
@jmgate jmgate deleted the ensure-ssh-client-is-installed branch November 20, 2025 14:19
@jmgate
Copy link
Collaborator Author

jmgate commented Nov 20, 2025

Well shoot. We still run into

SSH Key pair found, configuring signing...
mkdir: created directory '/github/home/.ssh'
***
4d04b340ba4ac06a205eb7fb725a9c0ad4211a20ae54ba953ab0bf267d0279bf  /github/home/.ssh/signing_key
/usr/local/bin/action-entrypoint: line 159: ssh-agent: command not found
/usr/local/bin/action-entrypoint: line 160: ssh-add: command not found

Is it perhaps a flaw in python-semantic-release?

@jmgate
Copy link
Collaborator Author

jmgate commented Nov 20, 2025

Filed python-semantic-release/python-semantic-release#1376 to see if we can get some guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants