-
Notifications
You must be signed in to change notification settings - Fork 37
feat: Vue 3 upgrade #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Vue 3 upgrade #236
Conversation
delete unused pages move View pages to view directory and rename pull router/store up to top level move mixin to utils fix 'make all' remove unused package and 'npm preview' command
don't open bundle analysis during build update package versions in readme
@input was passing an event rather than the value on-cancel wasn't being called at all clean up create experiment modal ui
adjust ws in dev mode
|
Is this still in progress? If so, it should be marked as Draft 😃 |
|
Sorry, we had a few extra hours and got a couple last minute fixes in! It is ready, we are not planning on having any more commits. Also, sorry for the incredibly large +/- git diff. I'd assume a large majority of that is from running the formatter -- the actual amount of meaningful changes is smaller (but still sizeable). |
|
Excellent! This is probably best reviewed by someone familiar with the Vue code, such as @activeshadow |
|
@causand22 I might be doing something dumb, but I pulled
and am getting this on startup of the UI:
|
That's very likely on our end. We've never used the JIT image, so I hadn't looked at that more than making sure the image builds |
@glattercj should be good now! |
activeshadow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not reviewed yet, so I'm not approving or requesting changes at this point. What I will request is that we squash this down to a (much) smaller number of commits before merging. 😂
I think I worry about the commit history a little too much...
I think we had wanted to keep it unsquashed in case there were any questions/debugging needed during the PR. Our time is limited to support this further, but I can squash it once it's been tested (also completely fine if someone else takes over the PR). |


Upgrade to Vue 3
Contributors: @jacdavi @causand22
Description
Updating the front end to use Vue 3 and newer versions of all tools. Quick overview:
Related Issue
Type of Change
Checklist
Additional Notes
KEY DEVELOPMENT CHANGE
env arguments are different for vite. Instead of VUE_APP_AUTH, it's now VITE_AUTH.
.envincluded with this PR.Smaller changes:
Marking this PR as a draft as some features still need testing (scorch).