Skip to content

Conversation

@causand22
Copy link
Contributor

Upgrade to Vue 3

Contributors: @jacdavi @causand22

Description

Updating the front end to use Vue 3 and newer versions of all tools. Quick overview:

  • Node version updated to latest (22 at time of PR)
  • Removing yarn for build process, using npm
  • Vue 2 updated to Vue 3
    • store: Vuex -> Pinia
    • requests: vue resources -> axios
    • build tool: vue-cli -> vite
  • buefy updated to v1.0 (vue 3 support)
  • Code organization, moved page base components to views/, separated some views into multiple components
  • Separate CSS files
  • code formatted using prettier
  • pages now load dynamically (making initial page loading quicker)
    • Config page has components load dynamically (editor dependencies) to make list load faster.

Related Issue

Type of Change

  • New feature
  • Documentation update

Checklist

  • This PR conforms to the process detailed in the Contributing Guide.
  • I have included no proprietary/sensitive information in my code.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested my code.

Additional Notes

KEY DEVELOPMENT CHANGE
env arguments are different for vite. Instead of VUE_APP_AUTH, it's now VITE_AUTH. .env included with this PR.

Smaller changes:

  • modifications to CSS
  • Certain dependencies changed for lower page size
  • added auto time out functionality (part of settings page)
    • changes made to go backend as well (added settings, one api route)
  • various bugfixes

Marking this PR as a draft as some features still need testing (scorch).

jacdavi and others added 30 commits July 8, 2025 22:43
delete unused pages
move View pages to view directory and rename
pull router/store up to top level
move mixin to utils
fix 'make all'
remove unused package and 'npm preview' command
don't open bundle analysis during build
update package versions in readme
@input was passing an event rather than the value
on-cancel wasn't being called at all

clean up create experiment modal ui
@causand22 causand22 marked this pull request as ready for review July 22, 2025 17:16
@GhostofGoes
Copy link
Collaborator

Is this still in progress? If so, it should be marked as Draft 😃

@causand22
Copy link
Contributor Author

Sorry, we had a few extra hours and got a couple last minute fixes in! It is ready, we are not planning on having any more commits.

Also, sorry for the incredibly large +/- git diff. I'd assume a large majority of that is from running the formatter -- the actual amount of meaningful changes is smaller (but still sizeable).

@GhostofGoes
Copy link
Collaborator

Excellent! This is probably best reviewed by someone familiar with the Vue code, such as @activeshadow

@GhostofGoes GhostofGoes requested a review from glattercj August 4, 2025 21:10
@glattercj
Copy link
Collaborator

@causand22 I might be doing something dumb, but I pulled

docker pull ghcr.io/causand22/sceptre-phenix/phenix-jit-ui:feat-vue3

and am getting this on startup of the UI:

image

@jacdavi
Copy link
Contributor

jacdavi commented Aug 7, 2025

@causand22 I might be doing something dumb, but I pulled

docker pull ghcr.io/causand22/sceptre-phenix/phenix-jit-ui:feat-vue3

and am getting this on startup of the UI:

image

That's very likely on our end. We've never used the JIT image, so I hadn't looked at that more than making sure the image builds

@jacdavi
Copy link
Contributor

jacdavi commented Aug 7, 2025

@causand22 I might be doing something dumb, but I pulled
docker pull ghcr.io/causand22/sceptre-phenix/phenix-jit-ui:feat-vue3
and am getting this on startup of the UI:
image

That's very likely on our end. We've never used the JIT image, so I hadn't looked at that more than making sure the image builds

@glattercj should be good now!

Copy link
Collaborator

@activeshadow activeshadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed yet, so I'm not approving or requesting changes at this point. What I will request is that we squash this down to a (much) smaller number of commits before merging. 😂

I think I worry about the commit history a little too much...

@jacdavi
Copy link
Contributor

jacdavi commented Sep 23, 2025

I have not reviewed yet, so I'm not approving or requesting changes at this point. What I will request is that we squash this down to a (much) smaller number of commits before merging. 😂

I think I worry about the commit history a little too much...

I think we had wanted to keep it unsquashed in case there were any questions/debugging needed during the PR. Our time is limited to support this further, but I can squash it once it's been tested (also completely fine if someone else takes over the PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants