Support for linux routers using FRRouting (FRR) #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhostofGoes
requested changes
Oct 5, 2025
| sysctl -w net.ipv4.conf.all.forwarding = 1 | ||
|
|
||
| #check if frr exists | ||
| if command -v 'frr' &>/dev/null; then |
Collaborator
There was a problem hiding this comment.
If this check fails, that should probably be logged somewhere?
| fi | ||
|
|
||
|
|
||
| # frr ospf config |
Collaborator
There was a problem hiding this comment.
what is the point of this comment?
activeshadow
requested changes
Oct 29, 2025
Collaborator
activeshadow
left a comment
activeshadow
left a comment
There was a problem hiding this comment.
I suggest this all be put into the vrouter app and that app be updated to handle vanilla Linux-based routers appropriately.
Also, minimega's minirouter (which is vanilla Linux-based) already supports OSPF. @JordanPeterson-nrel are you not able to use minirouter as an option?
| continue | ||
| } | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
I don't like this change... all of this should be in the vrouter app, not the startup app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for ospf on linux routers using FRRouting (FRR)
Description
Adds support to use ospf on outers using a linux image with FRR installed and configured to run the ospf daemon. This feature increases the support for an alternative router option when deploying an environment. Instead of using Vyos/Vyatta, one can use a linux box and not give up the functionality of the ospf protocol.
This support is basic functional ospf using default FRR hello and dead intervals. Additional FRR configurations are not included in this MR and should be considered in future updates.
Related Issue
Closes #242
Type of Change
Please select the type of change your pull request introduces:
Checklist
Additional Notes
Please provide any additional information or context for your pull request here.