Skip to content

Commit 742f730

Browse files
edited list_model_versions
1 parent 0090e47 commit 742f730

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

src/sasctl/_services/model_repository.py

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from warnings import warn
1111
import requests
1212
from requests.exceptions import HTTPError
13+
import traceback
1314

1415
from ..core import current_session, delete, get, sasctl_command
1516
from .service import Service
@@ -624,24 +625,31 @@ def list_model_versions(cls, model):
624625
"Cannot find link for version history for model '%s'" % model
625626
)
626627

627-
modelHistory = cls.request_link(
628+
629+
modelHistory = cls.request_link(
628630
link,
629631
"modelHistory",
630-
headers={"Accept": "application/vnd.sas.models.model.version"},
632+
headers={"Accept": "application/vnd.sas.collection+json"},
631633
)
632-
if modelHistory is None:
633-
return {}
634634

635635
return modelHistory
636636

637637
@classmethod
638-
def get_model_version(cls, model, version_id):
638+
def get_model_version(cls, model, version_id): #check if this now handles a return 1 case
639639

640640
model_history = cls.list_model_versions(model)
641-
model_history_items = model_history.get("items")
642641

643-
for i, item in enumerate(model_history_items):
644-
if item.get("id") == version_id:
642+
for item in model_history:
643+
if isinstance(item, str):
644+
if item == 'id' and dict(model_history)[item] == version_id:
645+
return cls.request_link(
646+
model_history,
647+
"self",
648+
headers={"Accept": "application/vnd.sas.models.model.version"},
649+
)
650+
continue
651+
652+
if item["id"] == version_id:
645653
return cls.request_link(
646654
item,
647655
"self",

0 commit comments

Comments
 (0)