-
Notifications
You must be signed in to change notification settings - Fork 58
Library Viewer optimization in ITC #1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I, Danila Grobov (s4642g) <danila.grobov@seb.se>, hereby add my Signed-off-by to this commit: 176ab4b I, Danila Grobov (s4642g) <danila.grobov@seb.se>, hereby add my Signed-off-by to this commit: c12016f I, Danila Grobov (s4642g) <danila.grobov@seb.se>, hereby add my Signed-off-by to this commit: 9d1aff6 I, Danila Grobov (s4642g) <danila.grobov@seb.se>, hereby add my Signed-off-by to this commit: 328b22d Signed-off-by: Danila Grobov (s4642g) <danila.grobov@seb.se>
Signed-off-by: Danila Grobov (s4642g) <danila.grobov@seb.se>
DCO Remediation Commit for Danila Grobov (s4642g) <danila.grobov@seb.se> I, Danila Grobov (s4642g) <danila.grobov@seb.se>, hereby add my Signed-off-by to this commit: 2ab7999 Signed-off-by: Danila Grobov (s4642g) <danila.grobov@seb.se>
Signed-off-by: Danila Grobov <danila.grob@gmail.com>
…zation Signed-off-by: Danila Grobov <danila.grob@gmail.com>
Signed-off-by: Danila Grobov <danila.grob@gmail.com>
…zation Signed-off-by: Danila Grobov <danila.grob@gmail.com>
I, Danila Grobov <danila.grob@gmail.com>, hereby add my Signed-off-by to this commit: 7e4d8a2 Signed-off-by: Danila Grobov <danila.grob@gmail.com>
I, Danila Grobov (s4642g) <danila.grobov@seb.se>, hereby add my Signed-off-by to this commit: b5785aa Signed-off-by: Danila Grobov (s4642g) <danila.grobov@seb.se>
Signed-off-by: Danila Grobov <danila.grob@gmail.com>
Signed-off-by: Danila Grobov <danila.grob@gmail.com>
#1466 is merged. Please rebase with latest main branch to reflect the real change here. Thank you. |
Signed-off-by: dmitrymk <dmitry.m.kolosov@gmail.com> DCO Remediation Commit for dmitrymk <dmitry.m.kolosov@gmail.com> I, dmitrymk <dmitry.m.kolosov@gmail.com>, hereby add my Signed-off-by to this commit: 8845e58 I, dmitrymk <dmitry.m.kolosov@gmail.com>, hereby add my Signed-off-by to this commit: 0e4e742 I, dmitrymk <dmitry.m.kolosov@gmail.com>, hereby add my Signed-off-by to this commit: 8d805a8 Signed-off-by: dmitrymk <dmitry.m.kolosov@gmail.com>
Merged the main branch and removed duplicates which were in script.ts. I still have a DCO warning. In the last commit message I included the following:
But looks like it did not work. Does remediation message needs to be the only message in commit? |
Signed-off-by: dmitrymk dmitry.m.kolosov@gmail.com DCO Remediation Commit for dmitrymk dmitry.m.kolosov@gmail.com I, dmitrymk dmitry.m.kolosov@gmail.com, hereby add my Signed-off-by to this commit: f341dd8 Signed-off-by: dmitrymk dmitry.m.kolosov@gmail.com
To fix the DCO issue, it will be easier to close this PR and create a new one. So I will do it. |
Summary
Similar to the approach used in PR #1466, updating getLibraries and getTables to use ADO DB connector instead of execution of a SAS code. That speeds up library and table refresh for ITC connection.
Testing
Tested using ITC connection. Updated ItcLibraryAdapter.test.ts.
This branch is based on the PR 1466, so we need to wait till it is merged into main first.