Skip to content

Library Viewer optimization in ITC #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 32 commits into from

Conversation

DmitryMK
Copy link
Contributor

@DmitryMK DmitryMK commented Jun 4, 2025

Summary
Similar to the approach used in PR #1466, updating getLibraries and getTables to use ADO DB connector instead of execution of a SAS code. That speeds up library and table refresh for ITC connection.

Testing
Tested using ITC connection. Updated ItcLibraryAdapter.test.ts.

This branch is based on the PR 1466, so we need to wait till it is merged into main first.

DanilaGrobovSEB and others added 28 commits April 13, 2025 20:53
I, Danila Grobov (s4642g) <danila.grobov@seb.se>, hereby add my Signed-off-by to this commit: 176ab4b
I, Danila Grobov (s4642g) <danila.grobov@seb.se>, hereby add my Signed-off-by to this commit: c12016f
I, Danila Grobov (s4642g) <danila.grobov@seb.se>, hereby add my Signed-off-by to this commit: 9d1aff6
I, Danila Grobov (s4642g) <danila.grobov@seb.se>, hereby add my Signed-off-by to this commit: 328b22d

Signed-off-by: Danila Grobov (s4642g) <danila.grobov@seb.se>
Signed-off-by: Danila Grobov (s4642g) <danila.grobov@seb.se>
DCO Remediation Commit for Danila Grobov (s4642g) <danila.grobov@seb.se>

I, Danila Grobov (s4642g) <danila.grobov@seb.se>, hereby add my Signed-off-by to this commit: 2ab7999

Signed-off-by: Danila Grobov (s4642g) <danila.grobov@seb.se>
Signed-off-by: Danila Grobov (s4642g) <danila.grobov@seb.se>
Signed-off-by: Danila Grobov <danila.grob@gmail.com>
…zation

Signed-off-by: Danila Grobov <danila.grob@gmail.com>
Signed-off-by: Danila Grobov <danila.grob@gmail.com>
…zation

Signed-off-by: Danila Grobov <danila.grob@gmail.com>
I, Danila Grobov <danila.grob@gmail.com>, hereby add my Signed-off-by to this commit: 7e4d8a2

Signed-off-by: Danila Grobov <danila.grob@gmail.com>
I, Danila Grobov (s4642g) <danila.grobov@seb.se>, hereby add my Signed-off-by to this commit: b5785aa

Signed-off-by: Danila Grobov (s4642g) <danila.grobov@seb.se>
Signed-off-by: Danila Grobov <danila.grob@gmail.com>
Signed-off-by: Danila Grobov <danila.grob@gmail.com>
@scnwwu
Copy link
Member

scnwwu commented Jun 10, 2025

#1466 is merged. Please rebase with latest main branch to reflect the real change here. Thank you.

Signed-off-by: dmitrymk <dmitry.m.kolosov@gmail.com>
DCO Remediation Commit for dmitrymk <dmitry.m.kolosov@gmail.com>
I, dmitrymk <dmitry.m.kolosov@gmail.com>, hereby add my Signed-off-by to this commit: 8845e58
I, dmitrymk <dmitry.m.kolosov@gmail.com>, hereby add my Signed-off-by to this commit: 0e4e742
I, dmitrymk <dmitry.m.kolosov@gmail.com>, hereby add my Signed-off-by to this commit: 8d805a8

Signed-off-by: dmitrymk <dmitry.m.kolosov@gmail.com>
@DmitryMK
Copy link
Contributor Author

#1466 is merged. Please rebase with latest main branch to reflect the real change here. Thank you.

Merged the main branch and removed duplicates which were in script.ts.

I still have a DCO warning. In the last commit message I included the following:

Signed-off-by: dmitrymk dmitry.m.kolosov@gmail.com
DCO Remediation Commit for dmitrymk dmitry.m.kolosov@gmail.com
I, dmitrymk dmitry.m.kolosov@gmail.com, hereby add my Signed-off-by to this commit: 8845e58
I, dmitrymk dmitry.m.kolosov@gmail.com, hereby add my Signed-off-by to this commit: 0e4e742
I, dmitrymk dmitry.m.kolosov@gmail.com, hereby add my Signed-off-by to this commit: 8d805a8

Signed-off-by: dmitrymk dmitry.m.kolosov@gmail.com

But looks like it did not work. Does remediation message needs to be the only message in commit?

@scnwwu
Copy link
Member

scnwwu commented Jun 11, 2025

@DmitryMK, please click the DCO link for detailed info. Looks like one commit f341dd8 is missing from the sign-off.

DmitryMK added 2 commits June 11, 2025 12:30
Signed-off-by: dmitrymk dmitry.m.kolosov@gmail.com
DCO Remediation Commit for dmitrymk dmitry.m.kolosov@gmail.com

I, dmitrymk dmitry.m.kolosov@gmail.com, hereby add my Signed-off-by to this commit: f341dd8

Signed-off-by: dmitrymk dmitry.m.kolosov@gmail.com
@DmitryMK
Copy link
Contributor Author

To fix the DCO issue, it will be easier to close this PR and create a new one. So I will do it.

@DmitryMK DmitryMK closed this Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants