Skip to content

Commit a483762

Browse files
committed
Suggestions from code review
1 parent b484885 commit a483762

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

backend/app/debug_info.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,7 @@ func (a *app) GenerateDebugInfo() (bool, error) {
216216
},
217217
})
218218
if err != nil {
219-
slog.Error("failed to open save dialog", slog.Any("error", err))
220-
return false, err
219+
return false, fmt.Errorf("failed to open save dialog: %w", err)
221220
}
222221
if filename == "" {
223222
// user canceled the save dialog
@@ -226,8 +225,7 @@ func (a *app) GenerateDebugInfo() (bool, error) {
226225

227226
err = a.generateAndSaveDebugInfo(filename)
228227
if err != nil {
229-
slog.Error("failed to generate debug info", slog.Any("error", err))
230-
return false, err
228+
return false, fmt.Errorf("failed to generate debug info: %w", err)
231229
}
232230

233231
return true, nil

frontend/src/lib/components/modals/ErrorDetails.svelte

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
allowOpeningDiscord = true;
3030
}
3131
} catch (error) {
32-
LogError(`GenerateDebugInfo failed: ${error}`);
3332
debugFileGenerationError = true;
3433
// Enable the Discord button so they can report the error
3534
allowOpeningDiscord = true;
@@ -121,7 +120,6 @@
121120
{/if}
122121
{#if !fullPageMode}
123122
<footer class="card-footer">
124-
<!-- Must lambda the onClose call for type matching to be happy -->
125123
<button class="btn" on:click={onClose}>
126124
<T defaultValue="Close" keyName="common.close" />
127125
</button>

0 commit comments

Comments
 (0)