Skip to content

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Jun 11, 2024

  • condense and refine change log
  • change names to GH handles
  • stick with version 0.23?
  • do we need a short tutorial for the new density estimator API and the new training interface?
  • update all license comments to Apache 2.0

@janfb janfb marked this pull request as ready for review June 11, 2024 16:03
@janfb janfb requested a review from michaeldeistler June 11, 2024 16:04
@janfb janfb self-assigned this Jul 26, 2024
@janfb janfb added this to the Hackathon and release 2024 milestone Aug 2, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (3b9be6a) to head (fbd366b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
- Coverage   86.08%   78.16%   -7.93%     
==========================================
  Files         114      117       +3     
  Lines        8662     8679      +17     
==========================================
- Hits         7457     6784     -673     
- Misses       1205     1895     +690     
Flag Coverage Δ
unittests 78.16% <100.00%> (-7.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sbi/__version__.py 100.00% <100.00%> (ø)
sbi/diagnostics/lc2st.py 95.97% <ø> (+0.02%) ⬆️
sbi/inference/posteriors/ensemble_posterior.py 50.00% <ø> (-37.97%) ⬇️
.../neural_nets/estimators/mixed_density_estimator.py 98.11% <ø> (ø)
sbi/neural_nets/factory.py 90.90% <ø> (ø)
sbi/neural_nets/net_builders/categorial.py 94.73% <ø> (ø)
sbi/sbi_types.py 100.00% <ø> (ø)

... and 63 files with indirect coverage changes

@janfb janfb force-pushed the docs-prepare-release branch from 1a37308 to 3423cf5 Compare August 27, 2024 20:03
@janfb janfb force-pushed the docs-prepare-release branch from 3423cf5 to b24075d Compare August 27, 2024 20:07
@janfb janfb force-pushed the docs-prepare-release branch from b24075d to 6c45578 Compare August 27, 2024 20:08
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton! I am wondering if we should split Major Changes and New Features into two subcategories (Major Changes, and New Features)?

Copy link
Contributor Author

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michaeldeistler michaeldeistler merged commit f3ce427 into main Aug 28, 2024
4 checks passed
@michaeldeistler michaeldeistler deleted the docs-prepare-release branch August 28, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants