Skip to content

Fix erroneous warnings about different devices #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix erroneous warnings about different devices #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sbi/utils/nn_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def check_net_device(

if isinstance(net, nn.Identity):
return net
if str(next(net.parameters()).device) != device:
if str(next(net.parameters()).device) != str(device):
warn(
message or f"Network is not on the correct device. Moving it to {device}.",
stacklevel=2,
Expand Down
4 changes: 2 additions & 2 deletions sbi/utils/user_input_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ def validate_theta_and_x(
assert theta.dtype == float32, "Type of parameters must be float32."
assert x.dtype == float32, "Type of simulator outputs must be float32."

if str(x.device) != data_device:
if str(x.device) != str(data_device):
warnings.warn(
f"Data x has device '{x.device}'. "
f"Moving x to the data_device '{data_device}'. "
Expand All @@ -724,7 +724,7 @@ def validate_theta_and_x(
)
x = x.to(data_device)

if str(theta.device) != data_device:
if str(theta.device) != str(data_device):
warnings.warn(
f"Parameters theta has device '{theta.device}'. "
f"Moving theta to the data_device '{data_device}'. "
Expand Down