Skip to content

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Aug 27, 2024

  • refactor first paragraphs
  • add new methods
  • add aAI to credits.
  • fix all links in code, tutorials and FAQ because we changed "tutorial <- tutorials"

fixes #1214

@janfb janfb added the docs Improvements or additions to documentation label Aug 27, 2024
@janfb janfb self-assigned this Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (b46c7c5) to head (bdd535c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
- Coverage   86.05%   78.16%   -7.90%     
==========================================
  Files         117      117              
  Lines        8672     8679       +7     
==========================================
- Hits         7463     6784     -679     
- Misses       1209     1895     +686     
Flag Coverage Δ
unittests 78.16% <ø> (-7.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sbi/inference/trainers/base.py 86.91% <ø> (ø)

... and 28 files with indirect coverage changes

Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton! Left some comments

@janfb janfb requested a review from michaeldeistler August 27, 2024 11:08
@janfb janfb force-pushed the refactor-readme branch 2 times, most recently from a3c54d9 to fd2aedb Compare August 27, 2024 19:43
@michaeldeistler
Copy link
Contributor

@janfb Could you take care of the SNPE->NPE rename in the readme?

Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@janfb janfb merged commit 2e31996 into main Aug 28, 2024
4 checks passed
@janfb janfb deleted the refactor-readme branch August 28, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor README
2 participants