fixup for failing hmc test #1247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldeistler
force-pushed
the
hmcfixup
branch
2 times, most recently
from
d3abfb7 to
8b10199
Compare
michaeldeistler
force-pushed
the
hmcfixup
branch
from
8b10199 to
5533b26
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
==========================================
- Coverage 86.05% 86.02% -0.04%
==========================================
Files 117 118 +1
Lines 8672 8679 +7
==========================================
+ Hits 7463 7466 +3
- Misses 1209 1213 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
janfb
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CD tests are failing on
mainright nowC2ST: 0.6028045112781955 <= (0.5 + 0.1)fortest_c2st_pymc_sampler_on_Gaussian. I cannot reproduce this failure locally (neither on python 3.9 nor on 3.12). However, to get github actions to run, I slightly increased the number of samples.