Skip to content

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Sep 12, 2024

Somehow the iid handling for NPE was failing because is was not checking for the shape > 1, but directly failing when x_is_iid=True.

@janfb janfb merged commit 9e5bed4 into main Sep 12, 2024
4 checks passed
@janfb janfb deleted the fix-iid-error-handling branch September 12, 2024 21:01
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.37%. Comparing base (299854e) to head (f9dfd85).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1276       +/-   ##
===========================================
- Coverage   89.24%   78.37%   -10.88%     
===========================================
  Files         119      119               
  Lines        8695     8698        +3     
===========================================
- Hits         7760     6817      -943     
- Misses        935     1881      +946     
Flag Coverage Δ
unittests 78.37% <100.00%> (-10.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../inference/potentials/posterior_based_potential.py 95.34% <100.00%> (ø)

... and 31 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant