Skip to content

Conversation

manuel-morales-a
Copy link
Contributor

What does this implement/fix? Explain your changes

This small PR fixes the random seed at the beginning of the SBC tutorial. In this way, the results that one obtains are reproducible and consistent with the text of the tutorial.

Does this close any currently open issues?

Fixes #1312.

Any relevant code examples, logs, error output, etc?

I have run the required linting and unit tests. The file I have changed does not present any errors (Maybe *.ipynb are not checked), but some other files do (to be addressed in a different issue/PR).

Any other comments?

N/a.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • I have read and understood the contribution
    guidelines
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have reported how long the new tests run and potentially marked them
    with pytest.mark.slow.
  • New and existing unit tests pass locally with my changes
  • I performed linting and formatting as described in the contribution
    guidelines
  • There are no conflicts with the main branch

For the reviewer:

  • I have reviewed every file
  • All comments have been addressed.

Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manuel-morales-a! 🙏

The execution count indicates that you executed the notebooks cells multiple times, probably for testing. For merging this, it would be nice to have all cells executed in order from top to bottom.
Could you please restart the kernel and execute all cells from top? E.g., in VSCode, just click restart and then run all.

@manuel-morales-a
Copy link
Contributor Author

You're right! Cells have been properly executed now!

Best,

Manuel

@janfb
Copy link
Contributor

janfb commented Dec 23, 2024

Great, thanks! Ready to be merged then 🎉

@janfb janfb merged commit f2c1cc3 into sbi-dev:main Dec 23, 2024
4 checks passed
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.65%. Comparing base (d3f22b5) to head (e2e9eee).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1336       +/-   ##
===========================================
- Coverage   89.40%   78.65%   -10.76%     
===========================================
  Files         118      118               
  Lines        8715     8722        +7     
===========================================
- Hits         7792     6860      -932     
- Misses        923     1862      +939     
Flag Coverage Δ
unittests 78.65% <ø> (-10.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 32 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-run and seed SBC tutorial
2 participants