Skip to content

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Feb 26, 2025

a couple of fixes for MNLE tests.

  • test mnle with conditions only for 1D discrete
  • fix vectorized evaluation of BinomialGammaPotential
  • fix sir init function
  • add pbar for sequential MCMC inits in general

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.18%. Comparing base (dd4aef7) to head (e6c56be).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1410       +/-   ##
===========================================
- Coverage   89.20%   78.18%   -11.03%     
===========================================
  Files         119      119               
  Lines        8877     8916       +39     
===========================================
- Hits         7919     6971      -948     
- Misses        958     1945      +987     
Flag Coverage Δ
unittests 78.18% <100.00%> (-11.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sbi/inference/posteriors/mcmc_posterior.py 83.58% <100.00%> (-2.57%) ⬇️
sbi/samplers/importance/sir.py 100.00% <100.00%> (ø)

... and 37 files with indirect coverage changes

@janfb janfb self-assigned this Feb 27, 2025
Copy link
Contributor

@manuelgloeckler manuelgloeckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

The change in SIR is the bug fix, right?

Otherwise I suppose the most notebook changes are clean up to remove the warnings? If not I would remove them from the PR.

@janfb janfb merged commit 6e9a309 into main Mar 5, 2025
6 of 7 checks passed
@janfb janfb deleted the fix-mnle-tests-and-example branch March 5, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants