-
Notifications
You must be signed in to change notification settings - Fork 196
refactoring noise_schedule and time schedule into base class #1481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactoring noise_schedule and time schedule into base class #1481
Conversation
966a44c
to
45b1e94
Compare
@manuelgloeckler So i've finished working on this.
If the commit history scares you, either squash them all or let me know. I can also close this draft and send another PR. |
- created noise_schedule method to be overwritten by derivatives - created times_schedules method to be overwritten by derivatives - created test on times_schedules - improvded docstrings
- added tests too - inspired by https://arxiv.org/abs/2206.00364
in addition: - added improved version to benchmarks (for later comparison) - created new class ImprovedVPScoreEstimator
to understand how the VE estimator is implemented
- without touching the forward function of ConditionalScoreEstimator - benchmarks show that this leads to very long training time without any performance improvements
5c0798a
to
833c17b
Compare
It's great to have it fixed! This PR will have merge conflicts with #1497 , so I decided to take a look. I have a question - as far as I understand, during inference the introduced time schedule is still ignored and the linear steps are generated here in score_posterior.py, is that correct? I am wondering whether it should be handled by the Diffuser object instead of the posterior. Currently, Diffuser.run just receives ts, but I think it would be great to save time_scheduler along with t_min and t_max in the constructor and then construct ts based on the provided num_steps. |
times_schedule
noise_schedule
This addresses #1437