-
Notifications
You must be signed in to change notification settings - Fork 196
Logit transform #1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logit transform #1485
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1485 +/- ##
==========================================
- Coverage 86.43% 82.54% -3.90%
==========================================
Files 135 135
Lines 10927 10931 +4
==========================================
- Hits 9445 9023 -422
- Misses 1482 1908 +426
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@anastasiakrouglova thanks for the updates! 🙏 is this ready for another round of reviews? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @anastasiakrouglova ! 🙏
I added a couple of comments and suggestions, but we are very close :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have anything to add - once the comments from @janfb are resolved we can merge!
Co-authored-by: Jan <janfb@users.noreply.github.com>
Co-authored-by: Jan <janfb@users.noreply.github.com>
Co-authored-by: Jan <janfb@users.noreply.github.com>
I changed the way we are z_scoring the data. Now, instead of
none
,independent
andstructured
, we have can alsologit
transform our input, to train in an unbound space:This implementation also allows logit-transforming the samples for numerically stable training when many samples are outside the prior bounds.