Deprecation Warnings for build_posterior stringly typed parameters #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1627 +/- ##
=======================================
Coverage ? 82.55%
=======================================
Files ? 135
Lines ? 10948
Branches ? 0
=======================================
Hits ? 9038
Misses ? 1910
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
abelaba
changed the title
janfb
reviewed
Jul 29, 2025
sbi/inference/trainers/fmpe/fmpe.py
Outdated
Comment on lines
103
to
107
| self.build_posterior, | ||
| locals(), | ||
| { | ||
| "vectorfield_sampling_parameters", | ||
| }, |
There was a problem hiding this comment.
formatting is a bit verbose here, can we reduce the number of lines by removing the trailing commas? If no, it's fine.
…rior arguments" This reverts commit be39800.
|
I have updated the previous implementation for raising deprecation warnings. Instead of duplicating the warning checks across each trainer subclass, I have centralized the check in the base class. |
janfb
reviewed
Aug 6, 2025
Co-authored-by: Jan <janfb@users.noreply.github.com>
Co-authored-by: Jan <janfb@users.noreply.github.com>
janfb
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deprecation warnings for the stringly-typed
build_posteriormethod parameters in all trainer classes and warns users to use theposterior_parametersparameter to pass posterior parameters instead of using the dictionary configurations. In addition, all the tutorials and tests have been updated to use the strongly typed dataclasses introduced in this PR. It also includes a how-to guide for using thePosteriorParametersdata classes.