Skip to content

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Jul 29, 2025

tarp test was failing due to the change in max samping batch size from #1624 . Increasing the simulation budget slightly fixed the problem.

Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a406410). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1628   +/-   ##
=======================================
  Coverage        ?   86.43%           
=======================================
  Files           ?      135           
  Lines           ?    10927           
  Branches        ?        0           
=======================================
  Hits            ?     9445           
  Misses          ?     1482           
  Partials        ?        0           
Flag Coverage Δ
unittests 86.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@janfb janfb merged commit 65ae720 into main Jul 30, 2025
13 checks passed
@janfb janfb deleted the fix-failing-tarp-test branch July 30, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants