Skip to content

Conversation

manuelgloeckler
Copy link
Contributor

Fixes #1561

@manuelgloeckler manuelgloeckler added the bug Something isn't working label Aug 13, 2025
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@ebb8c6f). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1636   +/-   ##
=======================================
  Coverage        ?   82.55%           
=======================================
  Files           ?      135           
  Lines           ?    10950           
  Branches        ?        0           
=======================================
  Hits            ?     9040           
  Misses          ?     1910           
  Partials        ?        0           
Flag Coverage Δ
unittests 82.55% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sbi/inference/potentials/score_fn_iid.py 88.62% <100.00%> (ø)

@manuelgloeckler
Copy link
Contributor Author

I just enabled some of the testing (which was previously completely skipped). With the bug fix now, jac_gauss also passes at 16 trials just like auto_gauss.

@manuelgloeckler manuelgloeckler requested review from gmoss13 and janfb and removed request for janfb August 13, 2025 12:44
Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for fixing this @manuelgloeckler and thanks to @touronc for spotting it! 🚀

@janfb janfb merged commit e9355bf into main Aug 13, 2025
9 checks passed
@janfb janfb deleted the 1561-computation-of-denoising-posterior-precision-matrix-in-jac-method-score_fn_iid branch August 13, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Computation of denoising posterior precision matrix in JAC method (score_fn_iid)

2 participants