Skip to content

fix xfail test, fix deprecation warnings #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

fix xfail test, fix deprecation warnings #1642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sbi/inference/trainers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,13 +678,13 @@ def _raise_deprecation_warning(

# Check if deprecated parameters are used
if (
kwargs.get("mcmc_method") == default_mcmc_method
or kwargs.get("mcmc_method") is None
kwargs.get("mcmc_method") is not None
and kwargs.get("mcmc_method") != default_mcmc_method
):
deprecated_params.append("mcmc_method")
if (
kwargs.get("vi_method") == default_vi_method
or kwargs.get("vi_method") is None
kwargs.get("vi_method") is not None
and kwargs.get("vi_method") != default_vi_method
):
deprecated_params.append("vi_method")

Expand Down
7 changes: 1 addition & 6 deletions tests/linearGaussian_vector_field_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,12 +350,7 @@ def test_vector_field_sde_ode_sampling_equivalence(vector_field_trained_model):
@pytest.mark.parametrize(
"iid_method, num_trial",
[
pytest.param(
"fnpe",
3,
id="fnpe-3trials",
marks=pytest.mark.xfail(reason="c2st to high, fixed in PR #1501/1544"),
),
pytest.param("fnpe", 3, id="fnpe-3trials"),
pytest.param("gauss", 3, id="gauss-3trials"),
pytest.param("auto_gauss", 8, id="auto_gauss-8trials"),
pytest.param("auto_gauss", 16, id="auto_gauss-16trials"),
Expand Down