-
Notifications
You must be signed in to change notification settings - Fork 196
Refactor RatioEstimator to subclass ConditionalEstimator and remove redundant builder protocols #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e hints to use DensityEstimatorBuilder
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
=======================================
Coverage ? 82.56%
=======================================
Files ? 134
Lines ? 11140
Branches ? 0
=======================================
Hits ? 9198
Misses ? 1942
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a great refactoring @abelaba! 👏
if we reconcile all the protocols into one then this should not be called DensityEstimatorBuilder
because it also concerns functions that build ratio estimators or vector field estimators. I suggest to do a renaming into ConditionalEstimatorBuilder
.
this is the only required change for now, I will do another full review afterwards - thanks! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too small things to fix, otherwise good to go 🚀
Co-authored-by: Jan <janfb@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR updates the
RatioEstimator
class to be a subclass ofConditionalEstimator
. It also removes theRatioEstimatorBuilder
andVectorFieldEstimatorBuilder
protocols, as these protocols can be represented using theDensityEstimatorBuilder
protocol.