Pull develop into branch#478
Merged
luciansmith merged 224 commits intoonly-call-loadPlugins-oncefrom Mar 11, 2026
Merged
Conversation
there are some untested things in here
…rously' into sk/test-rate-rule-converter-rigorously
- only run build if repo is ours
#455: ensure we dont crash on no children
The rate rule converter previously treated the absence of rate rules as an error, causing conversion to fail. This change corrects this behavior by downgrading the error to a warning and allowing the conversion to proceed successfully. This ensures that models without rate rules are handled gracefully.
Sk/log converter errors
Adds a check to prevent rate rule conversion when species from different compartments appear in the same rate rule. This change ensures that the converter correctly handles models with multiple compartments and avoids generating invalid or unexpected results. Also, adds example models for testing.
particularly useful given that std::list it does not exist in older versions
Adds derivative functions for trigonometric and hyperbolic functions, including their inverses. This completes the implementation of the derivative function for ASTNodes.
Bump version in preparation of new release
Allow to bypass suitability tests in raterule connverter
current release updated to list 5.21
#438: mark writeMathMLWithNamespaceToString as newobject
Also, set the parent correctly when adding one to an existing element.
The check_library_exists function breaks my build when building both zlib and libsbml at once. I get the error:
CMake Error at C:/Users/Lucian/Desktop/libroadrunner-deps-backup/build-debug/CMakeFiles/CMakeScratch/TryCompile-m25yy5/CMakeLists.txt:28 (target_link_libraries):
Error evaluating generator expression:
$<TARGET_LINKER_FILE:zlibstatic>
No target "zlibstatic"
If I then hit compile again, it works! But the first time, it fails, and it needs to work the first time for my github action.
This problem was obfuscated by it previously trying to assign the result to LIBZ_CMAKE_PATH, which already existed, so it... broke the check? Maybe? Anyway.
I don't think we need to check that the library exists anyway. We don't do it for any of the XML libraries, and only do it for BZip. Which would probably also break my build, but I'm not including bzip in my build at all.
By default no test for symbols from the library will be made, but if `ZLIB_CHECK_FOR_SYMBOLS` is defined the library will be checked.
Allow a model history parent to be set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build on push not working; I think it was fixed in develop.