Challenge tokenization #361
Conversation
Related: #347 (comment) |
There was a problem hiding this comment.
Looking good to me! Adding a few nitpick comments here:
-
Need to update the Header challenge name to "Tokenization"
-
I like to update the weird "—" dashes from AI, so it looks a bit less GPTed. Usually, a comma, period, or parentheses works well.
-
I think we could get rid of the
Challenge AI assistantparagraph, just tried it and answers and UX are not that great. I think it made sense in a pre-cursor rules era, maybe now we could add the Q/A faq in a cursor rule, since we already have the SE-2 context there. -
We could update the initial screenshot where the old name appears. Did a quick test with banana and I think it looks good, pasting it here:
escottalexander
force-pushed
the
challenge-tokenization
branch
from
97104a1 to
5e8976e
Compare
|
I have addressed all of your feedback @rin-st @pablo and updated the image assets with those provided by @andrealbiac. Should be all good here! |
| > 👛 Explore burner wallets in 🏗 Scaffold-ETH 2: open an incognito window and visit http://localhost:3000. You'll see a totally new address in the top-right. Copy it and send test funds from your first window using the **Faucet** button (bottom-left): | ||
|  | ||
|  |
There was a problem hiding this comment.
When I tried to preview markdown from Cursor with this type of link previously, it didn't work for me, and I've seen related gh discussions. So I thought it probably won't work from SRE website. But for some reason, in this branch, preview works. I think you don't need to change it for now, we can merge and test if it works or not. Just mentioning here that it could be broken
|
Great job, lgtm! We need to make preparation PRs in the grader and SRE repos, and then I think we'll be ready to merge I'll create them |
|
Also, please create a corresponding PR to change the Readme of |
|
Auto Grader PR: austintgriffith/speedrun-grader#28 SRE-v2 PR (thanks Rinat): BuidlGuidl/SpeedRunEthereum-v2#328 Update wording in main branch README: #367 |
|
I think we can merge this PR if it's ready, since it won't break anything (and one less thing to coordinate when publishing) |
There was a problem hiding this comment.
Yes, I think it's ready to merge. @escottalexander, please merge it if there's nothing to add
|
Merged! Thank you! |
This PR still needs an updated hero image when @andrealbiac is able to create it.
Super open to thoughts on this. I went back and forth on how to best explain "tokenization" and include it in a challenge. This is what I ended up with, just some README adjustments.
I added some context paragraphs and clarifying remarks. I also removed the OpenSea sidequest because they don't support testnets anymore. 😢 I tried hard to find an NFT marketplace that supported Sepolia but I did not succeed.
Let's keep in mind that this is the very first challenge so we want it to read as easily as possible. Please flag anything that seems confusing.
I am imagining we will just keep the old simple-nft-challenge around for awhile but remove it from the front-end once this one is complete.