You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it may make the most sense to rename MultiDict to SetMultiMap, and potentially make MultiMap into a generic trait.
It helps remove the @Deprecation warning if renamed back to MultiMap
"MultiMap" is a more universally used terminology for this type of collection. (e.g. Guava has ArrayListMultimap, ListMultimap, SetMultimap, and etc; C++ STL is std::multimap; Rust is MultiMap, Apache Commons is MultiMap, etc)
The existing name also does support or convey the collection type of the key's values. (e.g. it currently implements Set, but there is no way to extend it to use an Array, Vector or List instead)
The code still uses MultiMap in various locations (like in the hashcode!), and the CC[_] is MapFactory (e.g. not DictFactory)
There are no other Dictionary terms in any of the Scala collections. It's Map for any scala code, only the java converters have the mention of a dictionary. MultiDict isn't scala idiomatic.
The text was updated successfully, but these errors were encountered:
I think it may make the most sense to rename
MultiDict
toSetMultiMap
, and potentially makeMultiMap
into a generic trait.MultiMap
ArrayListMultimap
,ListMultimap
,SetMultimap
, and etc; C++ STL isstd::multimap
; Rust isMultiMap
, Apache Commons isMultiMap
, etc)Set
, but there is no way to extend it to use anArray
,Vector
orList
instead)MultiMap
in various locations (like in the hashcode!), and theCC[_]
isMapFactory
(e.g. notDictFactory
)Map
for any scala code, only the java converters have the mention of a dictionary.MultiDict
isn't scala idiomatic.The text was updated successfully, but these errors were encountered: