Fix insufficient number width allocated when using -print-lines
#23336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22505
The main problem of the crash was the combination of
-print-lines
and-explain
,along with the rare case where we need to display the
9-10
range for the line-range9..10
(which was represented in the codebase as
8..9
), that was given insufficient number width to begin with.Alongside the change, I also added newlines before the TypeMismatch explanation's tree output.
This can be debated, but without it
-explain -print-lines
looks like this:The error looks much nicer (imo!) with the change:
(I have no idea how to add a line range to the last
)
, perhaps something can be changedin the
.show
implementation, but it seems complicated...)Changes