-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: release artifacts of the new build to the new repository #23761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use the variables and secrets from the environment in the workflows Follows #23761 [skip ci]
developers := List( | ||
Developer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this change needed? The central sonatype where we would publish stable releases marks that developers
attribute are required
https://central.sonatype.org/publish/requirements/#developer-information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it as most of the people there are not involved in the development of Scala anymore. I wasn't aware it was mandatory for the releases. I'll add it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed that was the reason. The list might be modify to show the current state, or even better it could be potentially generated based on the compiler/MAINTENANCE.md
maintenance list section in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we could do this:
Developer(
id = "scala",
name = "The Scala Team",
email = "security@scala-lang.org",
url = url("https://github.com/scala")
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that can also work, that's exactly what Kotlin does https://repo1.maven.org/maven2/org/jetbrains/kotlin/kotlin-stdlib/2.2.0/kotlin-stdlib-2.2.0.pom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will use https://scala-lang.org too
Add workflow to release the artifacts of the new nightly to the new repository.
This is still not fully complete, but it does what we want it to do at the moment.
[skip ci]