-
Notifications
You must be signed in to change notification settings - Fork 29
Fix skewed colorful tree dot #8878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds an inline flex style to fix the ColoredDotIcon’s width at 10px within segment_list_item.tsx. No logic, event handling, or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
@MichaelBuessemeyer feel free to merge this if you are satisfied :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
frontend/javascripts/viewer/view/right-border-tabs/segments_tab/segment_list_item.tsx (1)
54-69
: Remove “fixes #8875” from the PR description
This PR only adds styling for ColoredDotIcon and does not modify any key‐handling or signup modal behavior.
🧹 Nitpick comments (2)
frontend/javascripts/viewer/view/right-border-tabs/segments_tab/segment_list_item.tsx (2)
61-66
: Prefer longhand flex properties for clarity and type-safety.Using
flexGrow/flexShrink/flexBasis
avoids magic-string shorthands and makes future tweaks easier.Apply this diff:
- flex: "0 0 10px", + flexGrow: 0, + flexShrink: 0, + flexBasis: 10,
58-66
: A11y: hide decorative dot from screen readers.If purely visual, mark it presentational to reduce SR noise.
Apply this diff:
- <span + <span + aria-hidden="true" + role="presentation" className="circle" style={{
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
frontend/javascripts/viewer/view/right-border-tabs/segments_tab/segment_list_item.tsx
(1 hunks)
🔇 Additional comments (1)
frontend/javascripts/viewer/view/right-border-tabs/segments_tab/segment_list_item.tsx (1)
65-66
: LGTM: flex-basis freeze keeps the dot circular in tight flex layouts.Setting
flex: "0 0 10px"
prevents shrinking and fixes the squashing. Looks correct and low-risk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks fixing this 🎉 🙏
Steps to test:
TODOs:
fixes #8779