Skip to content

Commit aeaa405

Browse files
committed
Merge branch 'refs/heads/master' into m2m-auth-refactoring
2 parents 8f5e6d3 + 759c306 commit aeaa405

File tree

12 files changed

+16
-28
lines changed

12 files changed

+16
-28
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
</parent>
1212

1313
<artifactId>scalecube-services-parent</artifactId>
14-
<version>2.12.6-SNAPSHOT</version>
14+
<version>2.12.7-SNAPSHOT</version>
1515
<packaging>pom</packaging>
1616
<name>ScaleCube-Services</name>
1717

services-api/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<parent>
99
<groupId>io.scalecube</groupId>
1010
<artifactId>scalecube-services-parent</artifactId>
11-
<version>2.12.6-SNAPSHOT</version>
11+
<version>2.12.7-SNAPSHOT</version>
1212
</parent>
1313

1414
<artifactId>scalecube-services-api</artifactId>

services-discovery/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>io.scalecube</groupId>
88
<artifactId>scalecube-services-parent</artifactId>
9-
<version>2.12.6-SNAPSHOT</version>
9+
<version>2.12.7-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>scalecube-services-discovery</artifactId>

services-examples/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<groupId>io.scalecube</groupId>
77
<artifactId>scalecube-services-parent</artifactId>
8-
<version>2.12.6-SNAPSHOT</version>
8+
<version>2.12.7-SNAPSHOT</version>
99
</parent>
1010

1111
<artifactId>scalecube-services-examples</artifactId>

services-gateway/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<parent>
88
<groupId>io.scalecube</groupId>
99
<artifactId>scalecube-services-parent</artifactId>
10-
<version>2.12.6-SNAPSHOT</version>
10+
<version>2.12.7-SNAPSHOT</version>
1111
</parent>
1212

1313
<artifactId>scalecube-services-gateway</artifactId>

services-gateway/src/main/java/io/scalecube/services/gateway/client/websocket/WebsocketGatewayClientTransport.java

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import io.netty.channel.ChannelOption;
55
import io.netty.handler.codec.http.HttpHeaderNames;
66
import io.netty.handler.codec.http.websocketx.PingWebSocketFrame;
7+
import io.netty.resolver.DefaultAddressResolverGroup;
78
import io.scalecube.services.Address;
89
import io.scalecube.services.ServiceReference;
910
import io.scalecube.services.api.ServiceMessage;
@@ -26,7 +27,6 @@
2627
import reactor.netty.Connection;
2728
import reactor.netty.http.client.HttpClient;
2829
import reactor.netty.resources.ConnectionProvider;
29-
import reactor.netty.resources.LoopResources;
3030

3131
public final class WebsocketGatewayClientTransport implements ClientChannel, ClientTransport {
3232

@@ -39,10 +39,8 @@ public final class WebsocketGatewayClientTransport implements ClientChannel, Cli
3939
private static final int CONNECT_TIMEOUT_MILLIS = (int) Duration.ofSeconds(5).toMillis();
4040

4141
private final GatewayClientCodec clientCodec;
42-
private final LoopResources loopResources;
4342
private final Duration keepAliveInterval;
4443
private final Function<HttpClient, HttpClient> operator;
45-
private final boolean ownsLoopResources;
4644

4745
private final AtomicLong sidCounter = new AtomicLong();
4846
private final AtomicReference<WebsocketGatewayClientSession> clientSessionReference =
@@ -52,11 +50,6 @@ private WebsocketGatewayClientTransport(Builder builder) {
5250
this.clientCodec = builder.clientCodec;
5351
this.keepAliveInterval = builder.keepAliveInterval;
5452
this.operator = builder.operator;
55-
this.loopResources =
56-
builder.loopResources == null
57-
? LoopResources.create("websocket-gateway-client", 1, true)
58-
: builder.loopResources;
59-
this.ownsLoopResources = builder.loopResources == null;
6053
}
6154

6255
public static Builder builder() {
@@ -74,7 +67,7 @@ public ClientChannel create(ServiceReference serviceReference) {
7467
final HttpClient httpClient =
7568
operator.apply(
7669
HttpClient.create(ConnectionProvider.newConnection())
77-
.runOn(loopResources)
70+
.resolver(DefaultAddressResolverGroup.INSTANCE)
7871
.option(ChannelOption.CONNECT_TIMEOUT_MILLIS, CONNECT_TIMEOUT_MILLIS)
7972
.option(ChannelOption.TCP_NODELAY, true)
8073
.headers(headers -> headers.set(HttpHeaderNames.CONTENT_TYPE, CONTENT_TYPE)));
@@ -196,15 +189,15 @@ private static Throwable getRootCause(Throwable throwable) {
196189

197190
@Override
198191
public void close() {
199-
if (ownsLoopResources) {
200-
loopResources.dispose();
192+
final var session = clientSessionReference.get();
193+
if (session != null) {
194+
session.close().doOnError(ex -> {}).subscribe();
201195
}
202196
}
203197

204198
public static class Builder {
205199

206200
private GatewayClientCodec clientCodec = CLIENT_CODEC;
207-
private LoopResources loopResources;
208201
private Duration keepAliveInterval = Duration.ZERO;
209202
private Function<HttpClient, HttpClient> operator = client -> client;
210203

@@ -215,11 +208,6 @@ public Builder clientCodec(GatewayClientCodec clientCodec) {
215208
return this;
216209
}
217210

218-
public Builder loopResources(LoopResources loopResources) {
219-
this.loopResources = loopResources;
220-
return this;
221-
}
222-
223211
public Builder httpClient(UnaryOperator<HttpClient> operator) {
224212
this.operator = this.operator.andThen(operator);
225213
return this;

services-security/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<parent>
88
<groupId>io.scalecube</groupId>
99
<artifactId>scalecube-services-parent</artifactId>
10-
<version>2.12.6-SNAPSHOT</version>
10+
<version>2.12.7-SNAPSHOT</version>
1111
</parent>
1212

1313
<artifactId>scalecube-services-security</artifactId>

services-testlib/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<parent>
88
<groupId>io.scalecube</groupId>
99
<artifactId>scalecube-services-parent</artifactId>
10-
<version>2.12.6-SNAPSHOT</version>
10+
<version>2.12.7-SNAPSHOT</version>
1111
</parent>
1212

1313
<artifactId>scalecube-services-testlib</artifactId>

services-transport-parent/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<groupId>io.scalecube</groupId>
77
<artifactId>scalecube-services-parent</artifactId>
8-
<version>2.12.6-SNAPSHOT</version>
8+
<version>2.12.7-SNAPSHOT</version>
99
</parent>
1010

1111
<artifactId>scalecube-services-transport-parent</artifactId>

services-transport-parent/services-transport-jackson/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<groupId>io.scalecube</groupId>
66
<artifactId>scalecube-services-transport-parent</artifactId>
7-
<version>2.12.6-SNAPSHOT</version>
7+
<version>2.12.7-SNAPSHOT</version>
88
</parent>
99

1010
<artifactId>scalecube-services-transport-jackson</artifactId>

0 commit comments

Comments
 (0)