Skip to content

Make auth/authz API and components to be more generic #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
artem-v opened this issue Feb 8, 2025 · 1 comment
Closed

Make auth/authz API and components to be more generic #890

artem-v opened this issue Feb 8, 2025 · 1 comment

Comments

@artem-v
Copy link
Contributor

artem-v commented Feb 8, 2025 •
edited
Loading

Main issue - there's way too much coupling on Map<String, String>:

  • io.scalecube.services.auth.CredentialsCodec
  • io.scalecube.services.transport.api.ServiceTransport.CredentialsSupplier
  • io.scalecube.services.auth.CredentialsSupplier
  • io.scalecube.services.auth.Authenticator
  • io.scalecube.services.transport.rsocket.ConnectionSetup#ConnectionSetup(java.util.Map<java.lang.String,java.lang.String>)
  • io.scalecube.services.transport.rsocket.RSocketClientTransport#getCredentials
  • io.scalecube.services.methods.ServiceMethodInvoker#authenticate

Intermediate auth/authz data must not be Map or List or something else, it must be abstract type T (or byte[]) and only edge components must declare how to interpret this type.
This was referenced Apr 17, 2025
Merged
Merged
@artem-v artem-v closed this as completed Apr 17, 2025
@artem-v
Copy link
Contributor Author

artem-v commented Apr 17, 2025

Closing. Fixed at #903.

@artem-v artem-v mentioned this issue Apr 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artem-v