Add missing tests#2391
Merged
bert-e merged 4 commits intodevelopment/2.14from Apr 24, 2026
Merged
Conversation
francoisferrand
force-pushed
the
improvement/ZENKO-5225
branch
from
6dfcd20 to
eb5301a
Compare
francoisferrand
force-pushed
the
improvement/ZENKO-5222
branch
from
308ab61 to
8fdde1b
Compare
delthas
approved these changes
Apr 23, 2026
francoisferrand
force-pushed
the
improvement/ZENKO-5222
branch
from
8fdde1b to
87dcc55
Compare
francoisferrand
force-pushed
the
improvement/ZENKO-5225
branch
from
eb5301a to
0922b25
Compare
francoisferrand
force-pushed
the
improvement/ZENKO-5222
branch
2 times, most recently
from
efad955 to
71ef4df
Compare
| uses: ./.github/workflows/alerts.yaml | ||
| secrets: inherit | ||
|
|
||
| check-scripts: |
Contributor
There was a problem hiding this comment.
Is it not possible to have these tests be javascript and merged with check-workflows ? haven't looked exactly at what they do but it seems related to checking github ci stuff
Contributor
Author
There was a problem hiding this comment.
I would have preferred, but the tests directly import the python script, so that individual functions can be tested unitary.
And the script was written in python as it is -afaik- the only tool available (in gha) which can process xml natively, without installing extra package.
francoisferrand
force-pushed
the
improvement/ZENKO-5225
branch
from
0922b25 to
cf91b66
Compare
francoisferrand
force-pushed
the
improvement/ZENKO-5222
branch
2 times, most recently
from
68d8441 to
50ce7e0
Compare
francoisferrand
force-pushed
the
improvement/ZENKO-5225
branch
from
6fbd7cd to
cf91b66
Compare
francoisferrand
force-pushed
the
improvement/ZENKO-5222
branch
from
50ce7e0 to
ee5ac08
Compare
francoisferrand
force-pushed
the
improvement/ZENKO-5222
branch
from
ee5ac08 to
0eaffd8
Compare
SylvainSenechal
approved these changes
Apr 24, 2026
Contributor
Author
|
/approve |
benzekrimaha
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: ZENKO-5222