Skip to content

Commit 46a5cbc

Browse files
authored
Merge pull request #309 from scholarly-python-package/develop
Version 1.2.2 to fix issues with the ScraperAPI
2 parents 78fb529 + c4d07a9 commit 46a5cbc

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

scholarly/_navigator.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,7 @@ def _get_page(self, pagerequest: str) -> str:
101101
w = random.uniform(1,2)
102102
time.sleep(w)
103103

104-
params = {}
105-
if self.pm._ScraperAPI_KEY:
106-
params = { 'api_key': self.pm._ScraperAPI_KEY, 'url': pagerequest }
107-
pagerequest = 'http://api.scraperapi.com'
108-
109-
resp = self._session.get(pagerequest, params=params, timeout=timeout)
104+
resp = self._session.get(pagerequest, timeout=timeout)
110105
self.logger.info("Session proxy config is {}".format(self._session.proxies))
111106

112107
has_captcha = self._requests_has_captcha(resp.text)

scholarly/_proxy_generator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ def ScraperAPI(self, API_KEY):
409409
assert API_KEY is not None
410410
self._ScraperAPI_KEY = API_KEY
411411

412-
self._use_proxy(http='http://api.scraperapi.com/?api_key='+API_KEY)
412+
self._use_proxy(http=f'http://scraperapi:{API_KEY}@proxy-server.scraperapi.com:8001')
413413

414414
def has_proxy(self)-> bool:
415415
return self._proxy_gen or self._can_refresh_tor

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
setuptools.setup(
77
name='scholarly',
8-
version='1.2.1',
8+
version='1.2.2',
99
author='Steven A. Cholewiak, Panos Ipeirotis, Victor Silva',
1010
author_email='steven@cholewiak.com, panos@stern.nyu.edu, vsilva@ualberta.ca',
1111
description='Simple access to Google Scholar authors and citations',

0 commit comments

Comments
 (0)