-
Notifications
You must be signed in to change notification settings - Fork 55
SPEC 13: Recommended targets and naming conventions #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,38 @@ | ||||||
--- | ||||||
title: "SPEC 13 — Recommended targets and naming conventions" | ||||||
number: 13 | ||||||
date: 2024-06-05 | ||||||
author: | ||||||
- "Pamphile Roy <roy.pamphile@gmail.com>" | ||||||
- "Matthias Bussonnier <>" | ||||||
- "Jarrod Millman <millman@berkeley.edu>" | ||||||
discussion: https://discuss.scientific-python.org/t/spec-13-recommended-targets-and-naming-conventions | ||||||
endorsed-by: | ||||||
--- | ||||||
|
||||||
## Description | ||||||
|
||||||
For consistency and decreased cognitive load across the ecosystem, this SPEC recommends naming conventions around various project aspects--such as project structure, repository layout, folder names, task runner and `pyproject.toml` targets name. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would also add some defaults for declaring optional dependencies: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. never mind, should have read all the comments below before commenting, as this was already mentioned. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test --> tests, bike shedding, but I'm 👎 on this. As it's test-dependencies in my view while the other recommendation is about a directory that contains the tests There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just hard to remember that "s" is for testing dir ( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. astropy does it this way since forever 😄 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not too fond of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We also limited the discussion to We can extend to other naming conventions later. |
||||||
|
||||||
From a cursory survey in the Scientific Python ecosystem, we discover some frustration from contributors and maintainer when moving from one project to another and belive that consistency will make it both easier for existing maintainer to contribute to manz project as well a decreae the confusion of new developers when contributing or creating new proejcts. | ||||||
tupui marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
||||||
## Implementation | ||||||
|
||||||
We recommend that by default the targets and folder names: | ||||||
- related to testing be named `tests` (and not `test`) | ||||||
- related to documentation be named `docs` (and not `doc`) | ||||||
- both should be lowercase. | ||||||
|
||||||
It is ok to have the singular aliases, but the plurals should always be the default. | ||||||
|
||||||
### Examples | ||||||
|
||||||
pyproj.toml | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ??
Suggested change
|
||||||
docs folder | ||||||
pip install .[] | ||||||
spin and dev.py | ||||||
tox | ||||||
|
||||||
## Notes | ||||||
|
||||||
 |
Uh oh!
There was an error while loading. Please reload this page.