-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[MRG] implement InstanceHardnessCV #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[MRG] implement InstanceHardnessCV #1125
Conversation
I made a small change in the way samples with large instance hardness are distributed over the folds. I first sort by label and then by proba before assigning the folds. Documentation is now also created. Let me know if there are questions or if there's something more I can do! |
Since I was late to review and I'm planning a release, I took the liberty to push a couple of changes directly. @fritshermans It looks really good already. I just change the module name to align on the scikit-learn naming ( We could extend later for multiclass if it makes any sense then. |
Thanks for looking into this Guillaume! Please let me know if there's anything I can do now |
As discussed on LinkedIn with @glemaitre, I implemented the InstanceHardnessCV splitter as described in my blog post.
'Instance hardness' refers to the difficulty to classify an instance. The way hard-to-classify instances are distributed over train and test sets has significant effect on the test set performance metrics.
Todo:
examples/
folder