corrected computation of #affected symvars

Christopher Hojny · Christopher Hojny · commit 3bccee8ad5a2 · 2025-05-24T17:15:06.000+02:00
diff --git a/src/scip/prop_symmetry.c b/src/scip/prop_symmetry.c
@@ -2052,9 +2052,9 @@ SCIP_RETCODE ensureSymmetryMovedpermvarscountsComputed(
    propdata->nmovedimplintpermvars = 0;
    propdata->nmovedcontpermvars = 0;
 
-   for (p = 0; p < propdata->nperms; ++p)
+   for (v = 0; v < propdata->npermvars; ++v)
    {
-      for (v = 0; v < propdata->npermvars; ++v)
+      for (p = 0; p < propdata->nperms; ++p)
       {
          if ( propdata->perms[p][v] != v )
          {
@@ -2078,6 +2078,7 @@ SCIP_RETCODE ensureSymmetryMovedpermvarscountsComputed(
                SCIPerrorMessage("Variable provided with unknown vartype\n");
                return SCIP_ERROR;
             }
+            break;
          }
       }
    }

Original file line number	Diff line number	Diff line change
`@@ -2052,9 +2052,9 @@ SCIP_RETCODE ensureSymmetryMovedpermvarscountsComputed(`
`2052`	`2052`	`propdata->nmovedimplintpermvars = 0;`
`2053`	`2053`	`propdata->nmovedcontpermvars = 0;`
`2054`	`2054`
`2055`		`- for (p = 0; p < propdata->nperms; ++p)`
	`2055`	`+ for (v = 0; v < propdata->npermvars; ++v)`
`2056`	`2056`	`{`
`2057`		`- for (v = 0; v < propdata->npermvars; ++v)`
	`2057`	`+ for (p = 0; p < propdata->nperms; ++p)`
`2058`	`2058`	`{`
`2059`	`2059`	`if ( propdata->perms[p][v] != v )`
`2060`	`2060`	`{`
`@@ -2078,6 +2078,7 @@ SCIP_RETCODE ensureSymmetryMovedpermvarscountsComputed(`
`2078`	`2078`	`SCIPerrorMessage("Variable provided with unknown vartype\n");`
`2079`	`2079`	`return SCIP_ERROR;`
`2080`	`2080`	`}`
	`2081`	`+ break;`
`2081`	`2082`	`}`
`2082`	`2083`	`}`
`2083`	`2084`	`}`