Skip to content

Commit 8783b9d

Browse files
committed
Merge remote-tracking branch 'origin/v9-minor'
2 parents 4508ae7 + 316d32a commit 8783b9d

File tree

9 files changed

+30
-8
lines changed

9 files changed

+30
-8
lines changed

CHANGELOG

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ Fixed bugs
134134
- fix possible segmentation fault when resetting local and global bounds of original variables after abnormal termination
135135
- compare coefficient scales to detect parallelism to avoid integral relaxations in detectRedundantConstraints() of cons_linear.c
136136
- remove coefficient information from linear constraint hashes in order to compare keys with tolerances
137+
- fixed NULL pointer dereference in SCIPtpiGetNumThreads() of TinyCThread interface if called before SCIPtpiInit(); now returns 0 in this case
137138

138139
Performance improvements
139140
------------------------

check/run.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,13 @@ OPTHOST=$(uname -n | sed 's/.zib.de//g' | sed 's/portal//g' | tr -cd '[:alpha:]'
7575

7676
# file on optimi to check for
7777
case "$OPTHOST" in
78-
opt | optc ) OPTIMIFILE=/nfs/optimi/QUOTAS ;;
78+
opt | optc )
79+
. /etc/os-release
80+
case "$ID" in
81+
debian ) OPTIMIFILE=/data/optimi/optimi/QUOTAS ;;
82+
ubuntu ) OPTIMIFILE=/nfs/optimi/QUOTAS ;;
83+
esac
84+
;;
7985
htccmp ) OPTIMIFILE=/data/optimi/optimi/QUOTAS ;;
8086
esac
8187

check/run_fscip.sh

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,20 @@ OPTHOST=$(uname -n | sed 's/.zib.de//g' | sed 's/portal//g' | tr -cd '[:alpha:]'
8989
# check if the scripts runs a *.zib.de host
9090
if $(hostname -f | grep -q zib.de) && $([[ "${OPTHOST}" == "opt" ]] || [[ "${OPTHOST}" == "optc" ]]);
9191
then
92+
# file on optimi to check for
93+
case "$OPTHOST" in
94+
opt | optc )
95+
. /etc/os-release
96+
case "$ID" in
97+
debian ) OPTIMIFILE=/data/optimi/optimi/QUOTAS ;;
98+
ubuntu ) OPTIMIFILE=/nfs/optimi/QUOTAS ;;
99+
esac
100+
;;
101+
htccmp ) OPTIMIFILE=/data/optimi/optimi/QUOTAS ;;
102+
esac
103+
92104
# access /optimi once to force a mount
93-
ls /nfs/optimi/QUOTAS >/dev/null 2>&1
105+
ls $OPTIMIFILE >/dev/null 2>&1
94106

95107
# check if /optimi is mounted
96108
MOUNTED=0
@@ -106,7 +118,7 @@ then
106118
exit 1
107119
fi
108120

109-
if [ -f /nfs/optimi/QUOTAS ]
121+
if [ -f $OPTIMIFILE ]
110122
then
111123
MOUNTED=1
112124
else

doc/inc/faq/faqtext.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,8 @@ SECTION: General Questions about SCIP
216216
SCIP supports nonlinear constraints of the form lhs ≤ f(x) ≤ rhs, where the function f(x) is an algebraic
217217
expression that can be represented as expression tree. Such an expression tree has constants and variables as terminal
218218
nodes and operands as non-terminal nodes.
219-
Expression operands supported by SCIP include addition, subtraction, multiplication, division, exponentiation and
220-
logarithm. Trigonometric functions are not yet supported by SCIP.
219+
Expression operands supported by SCIP include addition, subtraction, multiplication, division, exponentiation,
220+
logarithm, sine and cosine.
221221
</p>
222222
<p>
223223
Nonlinear objective functions are not supported by SCIP and must be modeled as constraint function.

make/local/make.opt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
QUEUETYPE = srun
2727
QUEUE = mip-dbg
2828
PPN = -1
29-
CLIENTTMPDIR = /local/tmp
3029
NOWAITCLUSTER = 1
3130
EXCLUSIVE = false
3231

make/local/make.opttest

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
QUEUETYPE = srun
2727
QUEUE = M620v2
2828
PPN = -1
29-
CLIENTTMPDIR = /local/tmp
3029
NOWAITCLUSTER = 1
3130
EXCLUSIVE = false
3231

make/make.darwin.clang

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,6 @@ ifeq ($(SHARED),true)
2323
FLAGS += -fPIC
2424
endif
2525
LINK_shared = -shared
26+
27+
FORTRANLIBS = -lgfortran
28+
FORTRAN_NAMING_CONVENTION = LCASE_DECOR

make/make.linux.clang

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ GMP_FLAGS =
99
GMP_LDFLAGS = -lgmp
1010
READLINE_FLAGS =
1111
READLINE_LDFLAGS= -lreadline -lncurses
12+
FORTRANLIBS = -lgfortran
13+
FORTRAN_NAMING_CONVENTION = LCASE_DECOR
1214
CFLAGS = -ffp-contract=off -std=c99 -D_XOPEN_SOURCE=600
1315
CXXFLAGS = -ffp-contract=off
1416

src/tpi/tpi_tnycthrd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,7 @@ int SCIPtpiGetNumThreads(
574574
void
575575
)
576576
{
577-
return _threadpool->nthreads;
577+
return _threadpool != NULL ? _threadpool->nthreads : 0;
578578
}
579579

580580
/** initializes tpi */

0 commit comments

Comments
 (0)