Merge branch 'fix-safe-success' into 'master'

Fix safe success

See merge request integer/scip!3856

Author: DominikKamp

src/scip/conflict_general.c

@@ -834,7 +834,8 @@ SCIP_RETCODE addRowToAggrRow(
    else
    {
       *success = FALSE;
-      SCIP_CALL( SCIPaggrRowAddRowSafely(set->scip, aggrrow, row, weight, negated ? -1 : 1, success) );
+      /**@todo add row safely */
+      /* SCIP_CALL( SCIPaggrRowAddRowSafely(set->scip, aggrrow, row, weight, negated ? -1 : 1, success) ); */
    }
 
    SCIPsetDebugMsg(set, " -> add %s row <%s>[%g,%g](lp depth: %d): dual=%g -> dualrhs=%g\n",

src/scip/cuts.c

@@ -2897,6 +2897,7 @@ SCIP_RETCODE SCIPaggrRowAddRowSafely(
    int i;
 
    assert(SCIPisExact(scip));
+   assert(success != NULL);
 
    /* update local flag */
    aggrrow->local = aggrrow->local || row->local;
@@ -2981,6 +2982,7 @@ SCIP_RETCODE SCIPaggrRowAddRowSafely(
    QUAD_ASSIGN(aggrrow->rhs, sidevalchg);
 
    /* add up coefficients */
+   *success = TRUE;
    SCIP_CALL( varVecAddScaledRowCoefsSafely(scip, aggrrow->inds, aggrrow->vals, &aggrrow->nnz, userow, weight, &sidevalchg, success) );
 
    sidevalchg += QUAD_TO_DBL(aggrrow->rhs);