Skip to content

Commit c8b0f80

Browse files
committed
Merge branch 'fix-objlim-issue-sepa_aggregation' into 'v91-bugfix'
only round down objective if integer See merge request integer/scip!3442
2 parents da242e6 + bb26eac commit c8b0f80

File tree

5 files changed

+3997
-4
lines changed

5 files changed

+3997
-4
lines changed

CHANGELOG

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
Fixed bugs
77
----------
88

9+
- fix bug in separator aggregation that caused incorrect terminations when for an integral objective the objective limit was set to a fractional value
10+
911
Performance improvements
1012
------------------------
1113

check/CMakeLists.txt

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -463,6 +463,10 @@ set(instances_Or
463463
"instances/Or/problem.cip\;0"
464464
)
465465

466+
set(instances_Objlim
467+
"instances/Issue/3715.cip\;0\;default\;0.01"
468+
)
469+
466470
#
467471
# Pairs of instances and settings
468472
#
@@ -536,6 +540,14 @@ macro(split_decompinstance instance)
536540
get_filename_component(basename ${instpath} NAME)
537541
endmacro(split_decompinstance)
538542

543+
macro(split_objliminstance instance)
544+
list(GET instance 0 path)
545+
list(GET instance 1 optval)
546+
list(GET instance 2 setting)
547+
list(GET instance 3 objlim)
548+
get_filename_component(basename ${path} NAME)
549+
endmacro(split_objliminstance)
550+
539551
macro(split_pair pair)
540552
list(GET pair 0 path)
541553
list(GET pair 1 optval)
@@ -695,6 +707,26 @@ foreach(instance ${instances_Indicator})
695707
)
696708
endforeach(instance)
697709

710+
#
711+
# test checking objectivelimits
712+
#
713+
foreach(instance ${instances_Objlim})
714+
split_objliminstance(instance)
715+
#
716+
# configure the batch file for this test by substituting placeholders in the in.file
717+
#
718+
configure_file(interactiveshell/objectivelimit.bat.in interactiveshell/objectivelimit-${basename}.bat)
719+
add_test(NAME Objlim-${setting}-${basename}
720+
COMMAND $<TARGET_FILE:scip> -b ${PROJECT_BINARY_DIR}/check/interactiveshell/objectivelimit-${basename}.bat
721+
)
722+
set_tests_properties(Objlim-${setting}-${basename}
723+
PROPERTIES
724+
PASS_REGULAR_EXPRESSION "Validation : Success"
725+
FAIL_REGULAR_EXPRESSION ERROR
726+
DEPENDS scip-build
727+
)
728+
endforeach(instance)
729+
698730
#
699731
# the following instances are not pure binary and hence cannot be written out in opb format
700732
#

0 commit comments

Comments
 (0)