Merge branch 'add_isfinite_checks' into 'master'

add SCIPisFinite() checks for constraint parameters

Closes #3792

See merge request integer/scip!3816

Author: svigerske

src/scip/cons_bounddisjunction.c

@@ -3360,6 +3360,10 @@ SCIP_RETCODE SCIPcreateConsBounddisjunction(
       for( v1 = 0; v1 < nvars; v1++ )
       {
          int v2;
+
+         /* check that the bounds are sensible, i.e., not nan or inf */
+         assert( SCIPisFinite(bounds[v1]) );
+
          for( v2 = v1+1; v2 < nvars; v2++ )
          {
             assert(vars[v1] != vars[v2] || (SCIPboundtypeOpposite(boundtypes[v1]) == boundtypes[v2]

src/scip/cons_cardinality.c

@@ -3647,6 +3647,15 @@ SCIP_RETCODE SCIPcreateConsCardinality(
 
    modifiable = FALSE;
 
+#ifndef NDEBUG
+   /* Check that the weights are sensible (not nan or inf); although not strictly needed, such values are likely a mistake. */
+   if ( nvars > 0 && weights != NULL )
+   {
+      for (v = 0; v < nvars; ++v)
+         assert( SCIPisFinite(weights[v]) );
+   }
+#endif
+
    /* find the cardinality constraint handler */
    conshdlr = SCIPfindConshdlr(scip, CONSHDLR_NAME);
    if( conshdlr == NULL )

src/scip/cons_linear.c

@@ -17897,8 +17897,14 @@ SCIP_RETCODE SCIPcreateConsLinear(
       return SCIP_PLUGINNOTFOUND;
    }
 
+   /* check that the given lhs/rhs are sensible, i.e., not nan or inf */
+   assert( SCIPisFinite(lhs) );
+   assert( SCIPisFinite(rhs) );
+
    for( j = 0; j < nvars; ++j )
    {
+      /* check that the given coefficients are sensible, i.e., not nan or inf */
+      assert( SCIPisFinite(vals[j]) );
       if( SCIPisInfinity(scip, REALABS(vals[j])) )
       {
          SCIPerrorMessage("coefficient of variable <%s> is infinite.\n", SCIPvarGetName(vars[j]));

src/scip/cons_varbound.c

@@ -5421,6 +5421,11 @@ SCIP_RETCODE SCIPcreateConsVarbound(
    SCIP_CONSHDLRDATA* conshdlrdata;
    SCIP_CONSDATA* consdata;
 
+   /* check that the given parameters are sensible, i.e., not nan or inf */
+   assert( SCIPisFinite(vbdcoef) );
+   assert( SCIPisFinite(lhs) );
+   assert( SCIPisFinite(rhs) );
+
    /* find the variable bound constraint handler */
    conshdlr = SCIPfindConshdlr(scip, CONSHDLR_NAME);
    if( conshdlr == NULL )