WIP/RFC: Do not call SCIPincludeObjExprhdlr in exprCopyhdlrObj #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/objscip/objexprhdlr.cpp (exprCopyhdlrObj): Comment out the call to SCIPincludeObjExprhdlr because this is called from the Java code. See scipopt#149 (comment) for details. TODO: This is a quick hack to fix the double free. Find a solution that is acceptable upstream and gets applied consistently also to constraint handlers etc.
|
I am submitting this mostly as an RFC, because my comment on the old pull request got no reply, and because I I need some solution for this issue for the work I am doing on JSCIPOpt. One alternative approach would be to have the |
|
I was a bit busy the last days, but hope to catch up with this in the next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/objscip/objexprhdlr.cpp (exprCopyhdlrObj): Comment out the call to SCIPincludeObjExprhdlr because this is called from the Java code.
See #149 (comment) for details.
TODO: This is a quick hack to fix the double free. Find a solution that is acceptable upstream and gets applied consistently also to constraint handlers etc.