fix: add readonly to promise type for flexibility #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using this library with `algoliasearch` (whose return types are always `Readonly<Promise<T>>`), I've had to use a wrapper function so that I can update those types. This allows for more flexibility (i.e. by reducing the required properties on the `Promise` object) and for use with more restrictive libraries like `algoliasearch`.
|
@scopsy I'd love to get this merged and released as soon as you've got time! Awesome work on this library by the way. I never knew that such a small piece of code could be so useful. |
nicholaschiang
added a commit
to tutorbookapp/tutorbook
that referenced
this pull request
Mar 1, 2021
Temporary fix until scopsy/await-to-js#47 is merged.
nicholaschiang
added a commit
to tutorbookapp/tutorbook
that referenced
this pull request
Mar 1, 2021
Temporary fix until scopsy/await-to-js#47 is merged.
nicholaschiang
added a commit
to tutorbookapp/tutorbook
that referenced
this pull request
Mar 7, 2021
Temporary fix until scopsy/await-to-js#47 is merged.
nicholaschiang
added a commit
to tutorbookapp/tutorbook
that referenced
this pull request
Mar 20, 2021
Adds the changes in scopsy/await-to-js#46 to our local type definitions (which exist because I'm waiting on scopsy/await-to-js#47).
nicholaschiang
added a commit
to tutorbookapp/tutorbook
that referenced
this pull request
Mar 20, 2021
Adds the changes in scopsy/await-to-js#46 to our local type definitions (which exist because I'm waiting on scopsy/await-to-js#47).
nicholaschiang
added a commit
to tutorbookapp/tutorbook
that referenced
this pull request
Mar 27, 2021
Adds the changes in scopsy/await-to-js#46 to our local type definitions (which exist because I'm waiting on scopsy/await-to-js#47).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this library with
algoliasearch(whose return types are alwaysReadonly<Promise<T>>), I've had to use a wrapper function so that I can update those types.This allows for more flexibility (i.e. by reducing the required properties on the
Promiseobject) and for use with more restrictive libraries likealgoliasearch.