Skip to content

Commit ba0026f

Browse files
committed
*Removed unnecessary test file
* Removed non_empty_props * Added test that checks duplicated and empty properties
1 parent b839be1 commit ba0026f

File tree

3 files changed

+42
-1280
lines changed

3 files changed

+42
-1280
lines changed

extruct/uniform.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,23 @@ def _uopengraph(extracted, with_og_array=False):
55
out = []
66
for obj in extracted:
77
# In order of appearance in the page
8-
properties = list(reversed(obj['properties']))
9-
# Set of non empty properties
10-
non_empty_props = {k for k, v in properties if v and v.strip()}
8+
properties = list(obj['properties'])
119
flattened = {}
10+
1211
for k, v in properties:
13-
if k not in non_empty_props:
12+
if k not in flattened.keys():
1413
flattened[k] = v
1514
elif v and v.strip():
16-
# If og_array isn't required or key isn't in flattened already
17-
if not with_og_array or k not in flattened:
18-
flattened[k] = v
15+
# If og_array isn't required add first non empty value
16+
if not with_og_array:
17+
flattened[k] = flattened[k] if flattened[k] and flattened[k].strip() else v
1918
else:
2019
if isinstance(flattened[k], list):
2120
flattened[k].append(v)
22-
else:
21+
elif flattened[k] and flattened[k].strip():
2322
flattened[k] = [flattened[k], v]
23+
else:
24+
flattened[k] = v
2425

2526
t = flattened.pop('og:type', None)
2627
if t:

0 commit comments

Comments
 (0)