Draft
Conversation
Author
|
Ideally this would work in both the bitmap and vector editors. Currently, certain tools in the bitmap editor (eg. paint brush and circle tool) don't support alpha. I can either work on implementing those (increasing the surface area of changes in this PR), or limit the new opacity slider to the vector editor. I'm looking into what kinds of changes need to be done to the bitmap tools to support the alpha channel. |
- add allowAlpha props to pass around whether alpha should be allowed - remove transparency if exists when switching to bitmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
#834
Proposed Changes
Adds a slider to the colour picker to change the opacity of colours + all the necessary plumbing to make it work
Screen.Recording.2024-06-26.at.11.17.36.mov
parse-colorfrom npm is unmaintained, and returns inconsistently. Hex colours like #00ffb9 have an alpha of 1, and rgba output ranges from 0-1, but for hex with the alpha part (eg. #00ffb9de) the scale is from 0-255Screen.Recording.2024-06-26.at.11.18.49.mov
Reason for Changes
Adds functionality to the paint editor that was previously difficult, introduces new users to the concept of colour transparency, etc.
Test Coverage
TODO